Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix a regular expression typo in a full sync job #4950

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

There's a mistaken || in a regular expression in a full sync job, which causes the job to end really quickly, so the next job times out.

This only impacts full syncs, the update syncs are short enough that the timeout doesn't happen.

Review

Anyone can review this PR, it's needed to fully apply the fix in #4945 to the cached state disks.
But it doesn't block other PRs merging.

Reviewer Checklist

  • Fix makes sense

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures labels Aug 25, 2022
@teor2345 teor2345 self-assigned this Aug 25, 2022
@teor2345 teor2345 requested a review from a team as a code owner August 25, 2022 19:54
@teor2345 teor2345 requested review from arya2 and removed request for a team August 25, 2022 19:54
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was skipping alternatives following the ||, makes sense, nice find

@teor2345
Copy link
Contributor Author

teor2345 commented Aug 25, 2022

It was my mistake originally!

(For people who need a reminder, | separates two alternative regular expressions, so A||B means "A or match everything or B", because an empty regular expression matches everything.)

@teor2345 teor2345 merged commit aa3b0af into main Aug 26, 2022
@teor2345 teor2345 deleted the ci-fix-full-sync branch August 26, 2022 03:31
@teor2345
Copy link
Contributor Author

I admin-merged this PR because it was failing with an "out of disk space" error.
That error is fixed on the main branch, but we need this fix to make the main branch CI run correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants