Revert: deserialize stored transactions in a rayon thread #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
|
I'm just doing a final test to make sure the speed increase wasn't due to the disk cache |
|
The disk cache only saved about 45 seconds (2%), so it's still worth merging this PR. |
Codecov Report
@@ Coverage Diff @@
## main #4933 +/- ##
==========================================
- Coverage 79.04% 78.97% -0.08%
==========================================
Files 309 309
Lines 38781 38772 -9
==========================================
- Hits 30656 30621 -35
- Misses 8125 8151 +26 |
|
@merifyio update |
teor2345
force-pushed
the
revert-state-tx-rayon
branch
from
487df16 to
040240e
Compare
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
@Mergifyio update |
✅ Branch has been successfully updated |
dconnolly
reviewed
Aug 29, 2022
|
This seems like a temporary error. https://github.com/ZcashFoundation/zebra/runs/8081095982?check_suite_focus=true#step:6:110 |
|
@Mergifyio refresh |
✅ Pull request refreshed |
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a
lightwalletdsync performance regression caused by PR #4801.While that change was more correct, it also causes a 20% slowdown in
lightwalletdsync performance:Close #4831.
Solution
Revert the rayon threads added in PR #4801.
Review
This PR is important for some of our upcoming users, but it is not urgent.
Reviewer Checklist