fix(network): send height to peers #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4904 +/- ##
==========================================
- Coverage 79.18% 79.03% -0.16%
==========================================
Files 309 309
Lines 38783 38786 +3
==========================================
- Hits 30710 30654 -56
- Misses 8073 8132 +59 |
teor2345
reviewed
Aug 10, 2022
There was a problem hiding this comment.
Looks great!
It seems like syncing is slow enough to fail CI, but I don't think that's because of the changes in this PR. But we'll need to fix the sync bugs before we merge any more PRs.
I'll try re-running those jobs, in case it was temporary network slowness.
teor2345
added
C-bug
teor2345
approved these changes
Aug 11, 2022
|
You could try:
|
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
It seems like Zebra appears in block explorers and nodes without this fix, so I'm reducing the priority to make room for other PRs in the queue. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
@Mergifyio update |
✅ Branch has been successfully updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra currently send height 0 in the
start_heightfield of theMessage::Version. This works protocol wise but DNS seeders expect a height here to classify peers. Resolves #4875Solution
Pretty simple solution, we already have everything available to end the height when we are building the version message.
Review
Anyone can review, i could be missing something as i thought this were going to be more complex. Local tests pass and i know this works while checkpointing, however i need to check a full sync. I expect the CI will assist me there.
Reviewer Checklist