1. fix(state): Stop reading redundant blocks for every FindHashes and FindHeaders request #4825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra reads 160-500 redundant blocks for each FindHashes or FindHeaders request.
The FindHeaders requests regularly take 5-10 seconds to answer.
This is a security issue because remote nodes can send these requests.
Solution
This PR contains a regression - the header queries used to be partially concurrent, now they block the rest of the state.
The next PR will implement full concurrency.
Review
This is an urgent PR to fix Zebra sync performance.
Reviewer Checklist