perf(commitments): generate sapling point outside the method #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
upbqdn
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
All looks good.
A suggestion regarding maintenance:
It is often desirable to keep variables close to where they are used. As described here https://users.rust-lang.org/t/lazy-static-inside-a-functions-scope/31700/2, statics are not reinitialized on subsequent function calls, so having V and R inside the function helps to keep the scope of the module a bit cleaner.
|
I admin-merged this PR because it is an urgent sync fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #4783
Solution
Generate the sapling points once as a global for sapling (f79c438).
Orchard is already doing it buy the lazy_static is inside the method. Maybe this is ok but i changed it anyway for consistency (4cbe1fc).
Review
Anyone can review.
Reviewer Checklist