Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump tokio from 1.19.2 to 1.20.0 #4780

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 14, 2022

Bumps tokio from 1.19.2 to 1.20.0.

Release notes

Sourced from tokio's releases.

Tokio v1.20.0

1.20.0 (July 12, 2022)

Added

Changed

  • time: remove src/time/driver/wheel/stack.rs (#4766)
  • rt: clean up arguments passed to basic scheduler (#4767)
  • net: be more specific about winapi features (#4764)
  • tokio: use const initialized thread locals where possible (#4677)
  • task: various small improvements to LocalKey (#4795)

Fixed

Documented

  • fs: warn about performance pitfall (#4762)
  • chore: fix spelling (#4769)
  • sync: document spurious failures in oneshot (#4777)
  • sync: add warning for watch in non-Send futures (#4741)
  • chore: fix typo (#4798)

Unstable

  • joinset: rename join_one to join_next (#4755)
  • rt: unhandled panic config for current thread rt (#4770)

#4677: tokio-rs/tokio#4677 #4741: tokio-rs/tokio#4741 #4755: tokio-rs/tokio#4755 #4758: tokio-rs/tokio#4758 #4762: tokio-rs/tokio#4762 #4764: tokio-rs/tokio#4764 #4766: tokio-rs/tokio#4766 #4767: tokio-rs/tokio#4767 #4769: tokio-rs/tokio#4769 #4770: tokio-rs/tokio#4770 #4772: tokio-rs/tokio#4772 #4777: tokio-rs/tokio#4777 #4791: tokio-rs/tokio#4791 #4793: tokio-rs/tokio#4793 #4795: tokio-rs/tokio#4795 #4798: tokio-rs/tokio#4798 #4806: tokio-rs/tokio#4806 #4808: tokio-rs/tokio#4808

Commits
  • b343767 chore: prepare Tokio v1.20.0 (#4830)
  • be620e9 chore: fix ci by hard-coding nightly version for miri (#4825)
  • ad942de chore: add a regression test for WASI (#4822)
  • 4daeea8 sync: add track_caller to public APIs (#4808)
  • 18efef7 signal: add track_caller to public APIs (#4806)
  • d8cad13 tests: alter integration tests for stdio to not use a handrolled cat implemen...
  • 8ed06ef chore: fix typo (#4798)
  • e6020c0 task: various small improvements to LocalKey (#4795)
  • 7f92bce tokio: use const initialized thread locals where possible (#4677)
  • 7ed2737 sync: Add has_changed method to watch::Ref (#4758)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team as code owners July 14, 2022 15:02
@dependabot dependabot bot requested review from conradoplg and removed request for a team July 14, 2022 15:02
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Low ❄️ labels Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #4780 (63a90c6) into main (485bac8) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 63a90c6 differs from pull request most recent head 247c894. Consider uploading reports for the commit 247c894 to get more accurate results

@@            Coverage Diff             @@
##             main    #4780      +/-   ##
==========================================
+ Coverage   78.78%   78.79%   +0.01%     
==========================================
  Files         306      306              
  Lines       37659    37664       +5     
==========================================
+ Hits        29668    29678      +10     
+ Misses       7991     7986       -5     

@teor2345 teor2345 requested review from teor2345 and removed request for a team and conradoplg July 15, 2022 00:25
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency change caused some builds to take 6 hours:
https://github.com/ZcashFoundation/zebra/runs/7342629415?check_suite_focus=true

That might be a hardware or network issue, let's re-run CI, and see if it passes.

@teor2345
Copy link
Contributor

@dependabot rebase

@teor2345
Copy link
Contributor

teor2345 commented Jul 15, 2022

I'd like to merge this PR to get better diagnostics in tokio code.
But we need to fix the crate compilation hangs first.

@teor2345 teor2345 requested a review from conradoplg July 15, 2022 00:30
@dependabot dependabot bot force-pushed the dependabot/cargo/tokio-1.20.0 branch 3 times, most recently from eaad6a4 to dcb1ae9 Compare July 17, 2022 22:43
@teor2345 teor2345 removed the request for review from conradoplg July 17, 2022 22:44
@teor2345 teor2345 assigned teor2345 and unassigned conradoplg Jul 17, 2022
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.19.2 to 1.20.0.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.19.2...tokio-1.20.0)

---
updated-dependencies:
- dependency-name: tokio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/tokio-1.20.0 branch from dcb1ae9 to 247c894 Compare July 17, 2022 22:44
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the compilation hangs were an infrastructure issue

@teor2345 teor2345 merged commit 81727d7 into main Jul 17, 2022
@teor2345 teor2345 deleted the dependabot/cargo/tokio-1.20.0 branch July 17, 2022 22:55
@teor2345
Copy link
Contributor

This version upgrade improves tokio diagnostics, and we're currently debugging tokio-related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants