Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump bitvec from 1.0.0 to 1.0.1 #4769

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 11, 2022

Bumps bitvec from 1.0.0 to 1.0.1.

Changelog

Sourced from bitvec's changelog.

1.0.1

Notes

Performance regressions have been reported between the development series 0.20 onwards and 1.0. It appears at least some of these regressions are due to the removal of the #[inline] attribute on bitvec public functions.

This attribute has been applied to all bitvec functions. You may see regressions in size of your final artifact, but you should also see improvements in your runtime speed. This is being tracked in [sharksforarms/deku#246].

Changes

  • The bits![static mut …] invocation has been made unsafe at the invocation site, in response to [Issue #156] filed by GitHub user [@​SimonSapin].

    This is technically an API break (formerly safe code now requires an unsafe block) but as no run-time behavior or compile-time types have changed except for this, and Rust considers breaking incorrect code to be acceptable within SemVer patches, I am publishing it as a patch.

  • GitHub user [@​dtolnay] fixed incorrect serde behaviors in [Pull Request #185]. This behavior was first reported in [Issue #167] by GitHub user [@​Nelarius].

  • Compilation no longer depends on environment variables set by Cargo, as requested in [Pull Request #162] by GitHub user [@​rocallahan].

  • The bitvec![val; len] macro can again take len as a runtime value as well as a compile-time constant. [Pull Request #160] was provided by GitHub user [@​coolreader18].

  • The return types of slice::Iter::by_{refs,vals} are restored to named types, rather than impl Iterator... opaque types. This allows them to be used directly in other sites. This defect was reported in [Issue #169] by GitHub user [@​dignifiedquire].

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner July 11, 2022 15:03
@dependabot dependabot bot requested review from conradoplg and removed request for a team July 11, 2022 15:03
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Low ❄️ labels Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #4769 (327b54e) into main (f7889ac) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4769      +/-   ##
==========================================
- Coverage   78.91%   78.86%   -0.06%     
==========================================
  Files         306      306              
  Lines       37664    37664              
==========================================
- Hits        29722    29702      -20     
- Misses       7942     7962      +20     

@conradoplg
Copy link
Collaborator

We want to use the same version as our dependencies unless there's a good reason not to

@dependabot ignore this minor version

@conradoplg conradoplg closed this Jul 13, 2022
@dependabot dependabot bot deleted the dependabot/cargo/bitvec-1.0.1 branch July 13, 2022 14:52
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 13, 2022

OK, I won't notify you about version 1.0.x again, unless you re-open this PR or update to a 1.0.x release yourself.

@str4d
Copy link
Contributor

str4d commented Jul 13, 2022

There's a good reason to use this dependency: it allegedly fixes significant performance regressions from 0.20 (which we did indeed observe when we migrated ff to bitvec 1). I haven't had time to check whether the changes fix our regression, but we should try it.

@teor2345
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot reopened this Jul 13, 2022
@dependabot dependabot bot restored the dependabot/cargo/bitvec-1.0.1 branch July 13, 2022 22:07
@teor2345
Copy link
Contributor

We might not want to wait for our dependencies on this.
(And if they haven't pinned their versions, they will automatically update when we do.)

Bumps [bitvec](https://github.com/bitvecto-rs/bitvec) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/bitvecto-rs/bitvec/releases)
- [Changelog](https://github.com/bitvecto-rs/bitvec/blob/main/CHANGELOG.md)
- [Commits](https://github.com/bitvecto-rs/bitvec/commits)

---
updated-dependencies:
- dependency-name: bitvec
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/bitvec-1.0.1 branch from 5aefd9c to 327b54e Compare July 13, 2022 22:13
@teor2345 teor2345 added P-High 🔥 I-slow Problems with performance or responsiveness and removed P-Low ❄️ labels Jul 13, 2022
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, compared with ferrilab/bitvec@072705d...440f4e6

@str4d
Copy link
Contributor

str4d commented Jul 14, 2022

Tested the bellman benchmarks against bitvec 1.0.1 and it looks like it does fix the performance regression we had when moving from bitvec 0.20 to bitvec 1.0.0:

multiexp/65536          time:   [118.45 ms 118.97 ms 119.49 ms]                           
                        change: [-14.833% -14.283% -13.768%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  8 (8.00%) low mild
  3 (3.00%) high mild

@teor2345
Copy link
Contributor

I'm admin-merging this because it fixes a performance issue.

@teor2345 teor2345 merged commit 61eeeb0 into main Jul 15, 2022
@teor2345 teor2345 deleted the dependabot/cargo/bitvec-1.0.1 branch July 15, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants