Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump criterion from 0.3.5 to 0.3.6 #4761

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 7, 2022

Bumps criterion from 0.3.5 to 0.3.6.

Changelog

Sourced from criterion's changelog.

[0.3.6] - 2022-07-06

Changed

  • MSRV bumped to 1.49
  • Symbol for microseconds changed from ASCII 'us' to unicode 'µs'
  • Documentation fixes
  • Clippy fixes
Commits
  • f9ccd05 Update version number and changelog.
  • 38fee32 Update dependencies.
  • abe3e86 Update changelog, fix typo in CONTRIBUTING.
  • 1c8873b Use the proper unit for microseconds (#567)
  • ff2ec14 set minimum patch version for atty (#587)
  • a2b8cae fix: missing closing parenthesis in examples (#585)
  • b61121b Ignore the --show-output flag used by libtest (#574)
  • 81ed3cc Apply clippy suggestions for rust-1.62 (#591)
  • 614236b docs: fix cargo-criterion stability status book page (#558)
  • 3dbb172 Bump MSRV to 1.49 as required by tokio. (#561)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner July 7, 2022 15:03
@dependabot dependabot bot requested review from teor2345 and removed request for a team July 7, 2022 15:03
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Low ❄️ labels Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #4761 (d70143b) into main (193e8c6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4761   +/-   ##
=======================================
  Coverage   78.78%   78.79%           
=======================================
  Files         309      309           
  Lines       38781    38781           
=======================================
+ Hits        30554    30556    +2     
+ Misses       8227     8225    -2     

@teor2345 teor2345 self-assigned this Jul 15, 2022
@teor2345 teor2345 added the A-diagnostics Area: Diagnosing issues or monitoring performance label Jul 15, 2022
teor2345
teor2345 previously approved these changes Jul 15, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes that we probably won't use

@dependabot dependabot bot force-pushed the dependabot/cargo/criterion-0.3.6 branch from e308f55 to b0509a7 Compare July 21, 2022 23:18
@teor2345
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/cargo/criterion-0.3.6 branch from b0509a7 to ed1d2e6 Compare July 31, 2022 22:54
teor2345
teor2345 previously approved these changes Jul 31, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@teor2345
Copy link
Contributor

teor2345 commented Aug 1, 2022

This dependency change needs a manual update to deny.toml to ignore some duplicate dependencies.

I might not get a chance to fix it, anyone else should feel free to do it.

@teor2345 teor2345 removed their assignment Aug 1, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/criterion-0.3.6 branch 2 times, most recently from 0d837c9 to 4e9ddd5 Compare August 3, 2022 23:44
Bumps [criterion](https://github.com/bheisler/criterion.rs) from 0.3.5 to 0.3.6.
- [Release notes](https://github.com/bheisler/criterion.rs/releases)
- [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](bheisler/criterion.rs@0.3.5...0.3.6)

---
updated-dependencies:
- dependency-name: criterion
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/criterion-0.3.6 branch from 4e9ddd5 to 52638c7 Compare August 4, 2022 22:11
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow duplicate dependencies in deny.toml

@teor2345 teor2345 self-assigned this Aug 6, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added exceptions for the duplicate dependencies

mergify bot added a commit that referenced this pull request Aug 6, 2022
@mergify mergify bot merged commit 360631f into main Aug 7, 2022
@mergify mergify bot deleted the dependabot/cargo/criterion-0.3.6 branch August 7, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-diagnostics Area: Diagnosing issues or monitoring performance A-rust Area: Updates to Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant