Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sync): Set the full verify concurrency limit to 5 blocks #4758

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix(sync): Set the full verify concurrency limit to 5 blocks #4758

merged 1 commit into from
Jul 6, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jul 6, 2022

Motivation

Syncing is a lot better, but still occasionally stalls.

We have other PRs that will make this better, but right now the easiest solution is to verify fewer blocks in parallel.

Solution

  • Set the full verify concurrency limit to 5 blocks

Review

Anyone can review this urgent PR, it blocks most other PRs merging.

Reviewer Checklist

  • Full sync passes (we can check this after we merge to main)

Follow Up Work

This should get better after:

@teor2345 teor2345 added C-bug Category: This is a bug P-Critical 🚑 I-hang A Zebra component stops responding to requests I-slow Problems with performance or responsiveness I-integration-fail Continuous integration fails, including build and test failures labels Jul 6, 2022
@teor2345 teor2345 requested a review from a team as a code owner July 6, 2022 21:28
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team July 6, 2022 21:28
@teor2345 teor2345 self-assigned this Jul 6, 2022
gustavovalverde
gustavovalverde approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teor2345
Copy link
Contributor Author

teor2345 commented Jul 6, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 1e1e4d4 into main Jul 6, 2022
@mergify mergify bot deleted the full-verify-5 branch July 6, 2022 21:53
@oxarbitrage oxarbitrage mentioned this pull request Jul 28, 2022
Merged
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavovalverde gustavovalverde gustavovalverde approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
C-bug Category: This is a bug I-hang A Zebra component stops responding to requests I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @gustavovalverde