change(state): Wrap commitment trees into Arc
#4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upbqdn
added
I-heavy
Codecov Report
@@ Coverage Diff @@
## main #4757 +/- ##
==========================================
- Coverage 78.80% 78.79% -0.01%
==========================================
Files 306 306
Lines 37661 37656 -5
==========================================
- Hits 29678 29671 -7
- Misses 7983 7985 +2 |
upbqdn
force-pushed
the
wrap-commitment-trees
branch
from
f9b33b5 to
4a3df89
Compare
The comment is not valid because Zebra uses `bridgetree::Frontier`s from the `incrementalmerkletree` crate to represent its note commitment trees. This `struct` does not support popping elements from the tree.
upbqdn
force-pushed
the
wrap-commitment-trees
branch
from
4a3df89 to
a0fc1cb
Compare
upbqdn
force-pushed
the
wrap-commitment-trees
branch
from
031e832 to
32548ed
Compare
|
It looks like these changes might help with some state hangs, but we need to test them after PR #4776 merges. |
teor2345
approved these changes
Jul 15, 2022
teor2345
requested review from
oxarbitrage
and removed request for
a team and
oxarbitrage
|
I admin-merged this PR because:
|
|
I thought I marked this PR as ready for review more than a week ago, but apparently, I didn't. Sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra maintains a copy of the same note commitment tree with each non-finalized state when handling multiple non-finalized states. It would be better to maintain only
Arcs, and use copy-on-write.Solution
This PR wraps Sprout, Sapling and Orchard note commitment trees into
Arcs in both finalized and non-finalized states.Closes #4766.
Review
We should check if the changes affect syncing speed.