Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade ECC dependencies #4699

Merged
merged 1 commit into from
Jun 27, 2022
Merged

deps: upgrade ECC dependencies #4699

merged 1 commit into from
Jun 27, 2022

Conversation

conradoplg
Copy link
Collaborator

@conradoplg conradoplg commented Jun 27, 2022

Motivation

ECC upgraded some of dependencies, and that includes improved batched halo2 verification which we want.

Specifications

Designs

Solution

  • Upgrade deps
  • Sync our zcash_proofs fork with upstream and point to that
  • Had to add some entries to deny.toml because those crates haven't been bumped in zcash itself, and that's what we need to use for zcash_script.

Review

With this we should be able to improve sync performance, so it's important.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #4699 (efcfe86) into main (e709420) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4699      +/-   ##
==========================================
+ Coverage   78.83%   78.93%   +0.10%     
==========================================
  Files         304      304              
  Lines       37506    37506              
==========================================
+ Hits        29568    29606      +38     
+ Misses       7938     7900      -38     

@teor2345 teor2345 added A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks P-High 🔥 I-heavy Problems with excessive memory, disk, or CPU usage I-slow Problems with performance or responsiveness labels Jun 27, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this!

mergify bot added a commit that referenced this pull request Jun 27, 2022
@mergify mergify bot merged commit 6b22794 into main Jun 27, 2022
@mergify mergify bot deleted the upgrade-ecc-dependecies branch June 27, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement I-heavy Problems with excessive memory, disk, or CPU usage I-slow Problems with performance or responsiveness NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants