Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(serialize): Improve ZcashSerialize docs #4693

Merged
merged 1 commit into from
Jun 28, 2022
Merged

doc(serialize): Improve ZcashSerialize docs #4693

merged 1 commit into from
Jun 28, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

I did this cleanup while working on another PR, and trying to understand the details of serialization.

Solution

  • Explain some serialization docs better
  • Clean up imports

Review

Anyone can review this PR, it is optional.

Reviewer Checklist

  • Existing tests pass

@teor2345 teor2345 added A-docs Area: Documentation C-cleanup Category: This is a cleanup P-Optional ✨ labels Jun 27, 2022
@teor2345 teor2345 self-assigned this Jun 27, 2022
@teor2345 teor2345 requested a review from a team as a code owner June 27, 2022 06:25
@teor2345 teor2345 requested review from dconnolly and removed request for a team June 27, 2022 06:25
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #4693 (1a4e8d7) into main (83aa42e) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4693      +/-   ##
==========================================
+ Coverage   78.87%   78.94%   +0.06%     
==========================================
  Files         304      304              
  Lines       37506    37506              
==========================================
+ Hits        29583    29609      +26     
+ Misses       7923     7897      -26

dconnolly
dconnolly approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

mergify bot added a commit that referenced this pull request Jun 27, 2022
@mergify
Merge of #4693
195abfb
@mergify mergify bot mentioned this pull request Jun 27, 2022
Closed
mergify bot added a commit that referenced this pull request Jun 28, 2022
@mergify
Merge of #4693
3b5decd
@mergify mergify bot mentioned this pull request Jun 28, 2022
Closed
mergify bot added a commit that referenced this pull request Jun 28, 2022
@mergify
Merge of #4693
d17329a
@mergify mergify bot mentioned this pull request Jun 28, 2022
Closed
@mergify mergify bot merged commit 54efbe9 into main Jun 28, 2022
@mergify mergify bot deleted the serialize-docs branch June 28, 2022 04:02
teor2345 added a commit that referenced this pull request Jun 28, 2022
@teor2345
Add draft changelog as of PR #4693
5963250
mergify bot pushed a commit that referenced this pull request Jun 29, 2022
@teor2345
Release Zebra 1.0.0-beta.12 (#4714)
9e277ed 
* Update Zebra to 1.0.0-beta.12

* Simplify tower-* versioning by updating both to 0.2.27

* Simplify version search and replace by removing an old version from the docs

* Update Cargo.lock

* Add draft changelog as of PR #4693

* Update CHANGELOG to PR #4680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

Assignees

@teor2345 teor2345

Labels
A-docs Area: Documentation C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @dconnolly