-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): Split docker run
into launch, logs
, and wait
#4690
Conversation
And update some comments.
a4f0a33
to
97b2657
Compare
I'm running full checkpoint and tip syncs here: They seem to have the right jobs, but we still need to check the jobs run correctly before we merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But @gustavovalverde might want to take a look later just to double check.
Motivation
This PR further splits up the
docker run
job.It is part of ticket #4661.
Solution
This PR splits the
docker run
jobs into 3 different jobs:docker run --detach
docker logs --tail all --follow
docker wait
It also fixes up some comments and formatting.
Review
This might be one for Gustavo, but anyone who understands GitHub workflows and docker should be able to review it.
Reviewer Checklist
Follow Up Work