Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): Split docker run into launch, logs, and wait #4690

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 27, 2022

Motivation

This PR further splits up the docker run job.

It is part of ticket #4661.

Solution

This PR splits the docker run jobs into 3 different jobs:

  • launch: docker run --detach
  • logs: docker logs --tail all --follow
  • result: docker wait

It also fixes up some comments and formatting.

Review

This might be one for Gustavo, but anyone who understands GitHub workflows and docker should be able to review it.

Reviewer Checklist

  • All GCP workflow jobs have launch, logs, and result steps
  • Failing jobs still fail

Follow Up Work

  • split the logs into checkpoint (sprout, sapling, orchard?) and full validation (sapling?, orchard)
  • require that full sync goes to 100%

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests labels Jun 27, 2022
@teor2345 teor2345 requested a review from a team as a code owner June 27, 2022 00:28
@teor2345 teor2345 requested review from conradoplg and removed request for a team June 27, 2022 00:28
@teor2345 teor2345 self-assigned this Jun 27, 2022
@teor2345
Copy link
Contributor Author

I'm running full checkpoint and tip syncs here:
https://github.com/ZcashFoundation/zebra/actions/runs/2566077841

They seem to have the right jobs, but we still need to check the jobs run correctly before we merge.

Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But @gustavovalverde might want to take a look later just to double check.

mergify bot added a commit that referenced this pull request Jun 27, 2022
@mergify mergify bot merged commit cbd703b into main Jun 28, 2022
@mergify mergify bot deleted the split-docker-run branch June 28, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-testing Category: These are tests I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants