fix(ci): actually create a cached state image after running a sync

[teor2345]

Motivation

A previous refactor made the cached state image job always get skipped.

Specifications

A default status check of success() is applied unless you include one of these functions.

https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions

This means that if any dependent job is skipped, the current job also gets skipped.
But we want to run after a successful job and an unused (skipped) job.

Solution

• use !failure() && !cancelled() to run after a skipped job

Review

This is blocking a bunch of work, and slowing down the tests.

Reviewer Checklist

• "Create cached state" jobs are not skipped in https://github.com/ZcashFoundation/zebra/actions/runs/2539724706

[teor2345]

I'm running a full and checkpoint sync here:
https://github.com/ZcashFoundation/zebra/actions/runs/2539724706

We need to check that both checkpoint and tip cached state disks are created before we merge to main.

[gustavovalverde]

I'm running the Job again after some fixes
Normal run: https://github.com/ZcashFoundation/zebra/actions/runs/2542050120
Disk rebuild run: https://github.com/ZcashFoundation/zebra/actions/runs/2542263828

[teor2345]

I'm running the Job again after some fixes
Normal run: https://github.com/ZcashFoundation/zebra/actions/runs/2542050120
Disk rebuild run: https://github.com/ZcashFoundation/zebra/actions/runs/2542263828

These seemed to work as intended.

The full sync timed out, and skipped creating the image (as expected), but that's going to be fixed in another PR.

[teor2345]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed