fix(log): Add some missing tracing spans #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
Codecov Report
@@ Coverage Diff @@
## main #4660 +/- ##
=======================================
Coverage 78.81% 78.82%
=======================================
Files 304 304
Lines 37509 37506 -3
=======================================
- Hits 29564 29563 -1
+ Misses 7945 7943 -2 |
upbqdn
approved these changes
Jun 22, 2022
|
@Mergifyio update |
✅ Branch has been successfully updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some zebra-network tasks are missing the global tracing span.
Review
Anyone can review this low-priority PR.
Reviewer Checklist
Follow Up Work
This might be related to the bug blocking ticket #4576, but there were also spans missing in
try_to_sync.