Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(log): Add block hash and height to syncer errors #4287

Merged
merged 1 commit into from
May 11, 2022
Merged

change(log): Add block hash and height to syncer errors #4287

merged 1 commit into from
May 11, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented May 4, 2022 •
edited by dconnolly
Loading

Motivation

It's hard to diagnose bugs like #4286, because syncer errors don't have the block hash or height.

Solution

  • Add block hash and height to syncer errors, except for permanent service readiness errors, where they don't matter
  • Split ValidationRequestError (block) and VerifierServiceError (permanent)

Review

Anyone can review this low priority PR.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

@teor2345 teor2345 added C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks P-Low ❄️ I-usability Zebra is hard to understand or use A-diagnostics Area: Diagnosing issues or monitoring performance labels May 4, 2022
@teor2345 teor2345 requested a review from a team as a code owner May 4, 2022 02:33
@teor2345 teor2345 self-assigned this May 4, 2022
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team May 4, 2022 02:33
@teor2345 teor2345 changed the base branch from main to fix-testnet-sync May 4, 2022 02:33
Base automatically changed from fix-testnet-sync to main May 4, 2022 22:04
@teor2345 teor2345 force-pushed the improve-syncer-errors branch from acb0bae to 1f4a4a5 Compare May 8, 2022 22:58
mergify bot added a commit that referenced this pull request May 11, 2022
@mergify
Merge of #4287
a2081f9
@mergify mergify bot mentioned this pull request May 11, 2022
Closed
48 tasks
mergify bot added a commit that referenced this pull request May 11, 2022
@mergify
Merge of #4287
1653c11
@mergify mergify bot mentioned this pull request May 11, 2022
Closed
48 tasks
mergify bot added a commit that referenced this pull request May 11, 2022
@mergify
Merge of #4287
9d33867
@mergify mergify bot mentioned this pull request May 11, 2022
Closed
48 tasks
@mergify mergify bot merged commit fee10ae into main May 11, 2022
@mergify mergify bot deleted the improve-syncer-errors branch May 11, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/network-reviewers

Assignees

@teor2345 teor2345

Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @dconnolly