Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(rfc): Cleanup transparent address index database design #4019

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 31, 2022

Motivation

  1. We want to name column families after what they actually contain
  2. We want to use standard terminology for item changes
  3. We want to delete unused database fields

Background

Standard terminology is:
https://en.wikipedia.org/wiki/Create,_read,_update_and_delete

Solution

  • Rename two location-based column families using loc
  • Use standard terminology for item changes: replace Never with Create
  • Remove AddressLocation from utxo_by_out_loc

Review

@conradoplg asked for the first change in PR #3999, and the third change in Discord.

Reviewer Checklist

  • Design makes sense

Follow Up Work

Update with the new names:

@teor2345 teor2345 added A-docs Area: Documentation C-cleanup Category: This is a cleanup P-Medium ⚡ lightwalletd any work associated with lightwalletd labels Mar 31, 2022
@teor2345 teor2345 requested a review from conradoplg March 31, 2022 20:14
@teor2345 teor2345 requested a review from a team as a code owner March 31, 2022 20:14
@teor2345 teor2345 self-assigned this Mar 31, 2022
@teor2345 teor2345 removed the request for review from a team March 31, 2022 20:51
@teor2345 teor2345 changed the title change(rfc): Rename column families and rename item changes change(rfc): Cleanup transparent address index database design Mar 31, 2022
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mergify bot added a commit that referenced this pull request Apr 1, 2022
@mergify mergify bot merged commit b895b89 into main Apr 1, 2022
@mergify mergify bot deleted the state-rfc-cf-rename branch April 1, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-cleanup Category: This is a cleanup lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants