fix(rpc): use the correct RPC error code for missing blocks #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
reviewed
Mar 28, 2022
Co-authored-by: Deirdre Connolly <[email protected]>
|
The tests failed due to #3991, so I restarted them. |
dconnolly
approved these changes
Mar 30, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
lightwalletdexpects a specific RPC error code for missing blocks.If it doesn't get that error code, it exits with a fatal error.
Specifications
This error code is not documented, but I opened a
zcashdticket here:zcash/zcash#5758
Solution
lightwalletdintegration testRelated changes:
Review
Anyone can review this PR.
This fix might be needed for tickets like #3512 (@jvff) and #3926 (@gustavovalverde). Without this fix,
lightwalletdexits with a fatal error when it reaches the tip.Reviewer Checklist