fix(sync): prevent synchronizer loop when very close to tip #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the use of loop labels and `continue` for control flow, and use early return from a separate method instead. This also allows removing the `started_once` flag.
Reduce duplicate code and make the main synchronization methods a little more concise to improve readability.
Leave active downloads running if the tips have been exhausted, because it could have reached the chain tip.
jvff
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3854 +/- ##
==========================================
- Coverage 78.90% 78.69% -0.21%
==========================================
Files 292 295 +3
Lines 33508 33769 +261
==========================================
+ Hits 26438 26576 +138
- Misses 7070 7193 +123 |
|
This fixes the issue for me 👍 |
teor2345
approved these changes
Mar 13, 2022
|
Is there something preventing this from moving out of draft? |
|
@jvff I've been running this since Friday and it's awesome, shall we promote this out of draft? |
jvff
added
C-bug
27 tasks
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra currently has some performance issues when block synchronization is close to the chain tip. During the investigation of the issue, I ran into two causes:
This PR fixes the first cause, and the second cause will very likely be fixed by the refactor to split the state service to increase throughput of read only requests (#3866).
Solution
Only cancel active block download tasks in case there's an error, preventing them from being cancelled when the prospective tips set is exhausted.
Closes #3375
Review
Reviewer Checklist
Follow Up Work
I'd like to have a regression test for this, but I'll try to open a separate optional PR for it.