-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7. feat(state): add a read-only state service stub #3835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-enhancement
Category: This is an improvement
P-Medium ⚡
I-slow
Problems with performance or responsiveness
A-rpc
Area: Remote Procedure Call interfaces
A-state
Area: State / database changes
labels
Mar 10, 2022
teor2345
changed the title
feat(state): add a read-only state service stub
7. feat(state): add a read-only state service stub
Mar 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #3835 +/- ##
==========================================
- Coverage 78.82% 78.65% -0.17%
==========================================
Files 293 293
Lines 33690 33737 +47
==========================================
- Hits 26555 26535 -20
- Misses 7135 7202 +67 |
3 tasks
teor2345
commented
Mar 10, 2022
teor2345
force-pushed
the
read-only-state-service
branch
from
March 11, 2022 03:52
74a4c1b
to
4bf96e9
Compare
teor2345
requested review from
gustavovalverde and
upbqdn
and removed request for
a team
March 11, 2022 03:52
1 task
teor2345
force-pushed
the
read-only-state-service
branch
from
March 11, 2022 07:49
8d5ab22
to
56a537a
Compare
oxarbitrage
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rpc
Area: Remote Procedure Call interfaces
A-state
Area: State / database changes
C-enhancement
Category: This is an improvement
I-slow
Problems with performance or responsiveness
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #3745, we want to add a read-only, cloneable state service, with no buffer or queue.
Designs
Share access to the best non-finalized chain and the finalized state.
Solution
Review
There is a lot of code changed in this PR series, it would be good to get it merged soon to avoid conflicts.
This doesn't do anything yet, the next few PRs will implement the read-only state requests, and add tests.
Reviewer Checklist
Follow Up Work