imp(test): turn on full backtraces and disable frame filtering #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
suggested changes
Mar 7, 2022
teor2345
added
A-diagnostics
|
I'm marking this as a low priority, because it only caused that one problem. |
We also need `RUST_LIB_BACKTRACE` as stated in: https://docs.rs/color-eyre/latest/color_eyre/#multiple-report-format-verbosity-levels https://doc.rust-lang.org/std/backtrace/index.html#environment-variables Co-authored-by: teor <[email protected]>
…CKTRACE and COLORBT_SHOW_HIDDEN
Codecov Report
@@ Coverage Diff @@
## main #3763 +/- ##
==========================================
- Coverage 78.91% 78.88% -0.04%
==========================================
Files 292 292
Lines 33311 33311
==========================================
- Hits 26287 26276 -11
- Misses 7024 7035 +11 |
teor2345
approved these changes
Mar 7, 2022
|
37 tasks
37 tasks
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #3489, the test failure was hard to diagnose, because
COLORBT_SHOW_HIDDEN=1hid some of the function calls we needed to see.Fixes #3536
Specifications
https://github.com/athre0z/color-backtrace/blob/master/CHANGELOG.md#v042-2020-05-19
Solution
Review
Anyone can review this