fix(ci): also check for duplicate dependencies with optional features off #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This duplicate was removed by PR #3572, but other duplicates still exist.
teor2345
added
C-bug
gustavovalverde
approved these changes
Feb 21, 2022
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are only checking for duplicate dependencies with all our optional features on.
But we might get different dependencies when all features are off. So we should check that case too.
Solution
Review
@gustavovalverde can review this PR.
This PR blocks all open PRs that change dependencies:
Merged PRs:
increase_nofile_limitfunction from rlimit 0.7.0 #3539 - I checked this PR, it passes the extra dependency checksReviewer Checklist