Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): make the purpose of each sync test clearer #3574

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 17, 2022

Motivation

We're about to add a full sync test in #1592, but the names of the existing tests are confusing.

Solution

Change the id, name, and add comments for each sync test.

The test from #1592 would look something like:

  # Test that Zebra syncs and validates from an empty state to the chain tip
  test-empty-to-tip-sync:
    name: Test sync from an empty state to the chain tip

Review

@gustavovalverde can review this PR.

Reviewer Checklist

  • Config and comments make sense

Follow Up Work

Add the full sync test:

@teor2345 teor2345 added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ I-usability Zebra is hard to understand or use labels Feb 17, 2022
@teor2345 teor2345 self-assigned this Feb 17, 2022
@mergify mergify bot merged commit e182c33 into main Feb 17, 2022
@mergify mergify bot deleted the ci-sync-name-docs branch February 17, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants