fix: generate well-formed finalSaplingRoot in Arbitrary implementation #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
approved these changes
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #3573 +/- ##
==========================================
+ Coverage 78.34% 80.31% +1.97%
==========================================
Files 267 276 +9
Lines 31526 32251 +725
==========================================
+ Hits 24698 25902 +1204
+ Misses 6828 6349 -479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #3544 we added a missing validation for the block commitments pre-Heartwood, when it's the Sapling note commitment tree root. It must be in the correct range.
However, this made a test fail since the Arbitrary implementation did not generate well-formed values, and the PR ended up being accidentally merged.
Specifications
Designs
Solution
I just noticed the issue so I didn't create an issue for it.
Review
Anyone can review. It's urgent because it makes all test flows after #3544 merged to fail.
Reviewer Checklist
Follow Up Work