fix(rfc): rename some lightwalletd database types #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-docs
``` fastmod BlockTransactionCount HeightTransactionCount fastmod FirstOutLocation TransparentAddrLoc ```
teor2345
force-pushed
the
lightwalletd-state-rfc-fix
branch
from
10dba81 to
f86d068
Compare
teor2345
requested review from
oxarbitrage and
jvff
and removed request for
oxarbitrage
jvff
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the
lightwalletddatabase types had confusing names.Solution
Add sub-headings to the RocksDB column family table.
Use names that represent what a type does, not how it is encoded:
Review
@jvff can review this change.
Reviewer Checklist