Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): evaluate "if" conditions correctly and use last disk SHA #3556

Merged
merged 5 commits into from
Feb 16, 2022
Merged

fix(test): evaluate "if" conditions correctly and use last disk SHA #3556

merged 5 commits into from
Feb 16, 2022

Conversation

gustavovalverde
Copy link
Member

Motivation

  • Full test sync was using older SHA's from a very old successful run.
  • Disk regeneration was always running, as the condition was being wrongly evaluated

Solution

  • Use disk short SHA from the actual run, when the conditions are met
  • Download the short SHA file from runs that are not successful as a whole, but the write step was done.
  • Evaluate if condition to a single false or true statement

Reviewer Checklist

  • Tests for Expected Behaviour

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 labels Feb 16, 2022
@gustavovalverde
imp(test): allow test stateful sync after disk regeneration
a263a87 
This takes is fast enough, so it shouldn't do any harm if run just after a ~3 hours test
@gustavovalverde gustavovalverde changed the title fix(test): evaluate if conditions correctly and use right disk SHA fix(test): evaluate "if" conditions correctly and use right disk SHA Feb 16, 2022
@gustavovalverde gustavovalverde changed the title fix(test): evaluate "if" conditions correctly and use right disk SHA fix(test): evaluate "if" conditions correctly and use last disk SHA Feb 16, 2022
conradoplg
conradoplg requested changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a question

.github/workflows/test.yml Show resolved Hide resolved
@mergify mergify bot merged commit 2e61998 into main Feb 16, 2022
@mergify mergify bot deleted the fix-tests-short-sha branch February 16, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

@dconnolly dconnolly Awaiting requested review from dconnolly

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavovalverde @conradoplg