Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): create disk from image before mounting #3550

Merged
merged 1 commit into from
Feb 16, 2022
Merged

fix(test): create disk from image before mounting #3550

merged 1 commit into from
Feb 16, 2022

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Feb 16, 2022 •
edited
Loading

Motivation

Sync test in GCP container creation was failing as the disk trying to be mounted does not exist

Solution

Sync test must create a disk from the previous image before mounting it

Review

Anyone can review it

Reviewer Checklist

  • Tests for Expected Behaviour

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ labels Feb 16, 2022
@gustavovalverde gustavovalverde self-assigned this Feb 16, 2022
teor2345
teor2345 approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@mergify mergify bot merged commit 8023ab1 into main Feb 16, 2022
@mergify mergify bot deleted the fix-stateful-sync branch February 16, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavovalverde @teor2345