merge-queue: embarking main (b9ab6c6), #3542 and [#3522 + #3459] together #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
- Use a more ENV configurable Dockerfile - Remove cloudbuild dependency - Use compute optimized machine types - Use SSD instead of normal hard drives - Move Sentry endpoint to secrets - Use a single yml for auto & manual deploy - Migrate to Google Artifact Registry
- Use a more ENV configurable Dockerfile - Remove cloudbuild dependency - Use compute optimized machine types - Use SSD instead of normal hard drives - Move Sentry endpoint to secrets - Use a single yml for auto & manual deploy - Migrate to Google Artifact Registry
Also substitute defaults with parameters sent through the workflow_dispatch
Caching from the latest image is one of the main reasons to add this extra tag. Before this commit, the inline cache was not being used.
The inline cache exporter only supports `min` cache mode. To enable `max` cache mode, push the image and the cache separately by using the registry cache exporter. This also allows for smaller release images.
We're leveraging the registry to cache the actions, instead of using the 10GB limits from Github Actions cache storage
Use interactive shells for manual and test deployments. This allow greater flexibility if troubleshooting is needed inside the machines
Instead of using a VM to SSH into in to build and test. Build in GHA (to have the logs available), run the workspace tests in GHA, and just run the sync tests in GCP Use a cintainer VM with zebra's image directly on it, and pass the needed parameters to run the Sync past mandatory checkpoint.
Compiling might be slow because different steps are compiling the same code 2-4 times because of the variations
GHA is transforming is somehow transforwing the variable to lowercase also, so we're changint it to adapt to it
Using the SHA from the base, creates confusion and it's not accurate with the SHA being shown and used on GitHub. We have to keep both as manual runs with `workflow_dispatch` does not have a PR SHA
There's no impact in this workflow when a change is done in the dockerfile
… commands afterwards in a different step. As GHA TTY is not working as expected, and workarounds does not play nicely with `gcloud compute ssh` actions/runner#241 (comment) we decided to get the container name from the logs, log directly to the container and run the cargo command from there.
Co-authored-by: teor <[email protected]>
This allows to follow logs in Github Actions terminal, while the GCP container is still running. Just delete the instance when following the logs ends successfully or fails
This allows to follow logs in Github Actions terminal, while the GCP container is still running. Just delete the instance when following the logs ends successfully or fails
23 tasks
Codecov Report
@@ Coverage Diff @@
## main #3548 +/- ##
==========================================
+ Coverage 78.34% 80.52% +2.17%
==========================================
Files 267 274 +7
Lines 31526 32256 +730
==========================================
+ Hits 24698 25973 +1275
+ Misses 6828 6283 -545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully 🎉
Branch main (b9ab6c6), #3542 and [#3522 + #3459] are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of [#3522 + #3459].
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
mediumfor merge:check-success=Build (+stable) on ubuntu-latestcheck-neutral=Build (+stable) on ubuntu-latestcheck-skipped=Build (+stable) on ubuntu-latestcheck-success=Build (+stable) zebra-chain w/o features on ubuntu-latestcheck-neutral=Build (+stable) zebra-chain w/o features on ubuntu-latestcheck-skipped=Build (+stable) zebra-chain w/o features on ubuntu-latestcheck-success=Test (+stable) on ubuntu-latestcheck-neutral=Test (+stable) on ubuntu-latestcheck-skipped=Test (+stable) on ubuntu-latestcheck-success=Test (+stable) on macOS-latestcheck-neutral=Test (+stable) on macOS-latestcheck-skipped=Test (+stable) on macOS-latest#approved-reviews-by>=1[🛡 GitHub branch protection]#changes-requested-reviews-by=0[🛡 GitHub branch protection]#review-threads-unresolved=0[🛡 GitHub branch protection]check-success=Test (+stable) on ubuntu-latestcheck-success=Test (+stable) on macOS-latestcheck-success=Test (+stable) on windows-latestcheck-success=Coverage (+nightly)More informations about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com