fix(test): simplify resource conflict test to avoid CI failures #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the test would wait 10 seconds for the process to launch. Now it waits until the process has used the conflicting resource.
|
The (This PR doesn't change any dependencies, so there's nothing new for them to check.) |
Codecov Report
@@ Coverage Diff @@
## main #3537 +/- ##
==========================================
+ Coverage 78.34% 80.44% +2.10%
==========================================
Files 267 274 +7
Lines 31526 32229 +703
==========================================
+ Hits 24698 25926 +1228
+ Misses 6828 6303 -525 |
conradoplg
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, the resource conflict tests would wait 10 seconds for the process to launch. But I think this might be causing test failures.
Now the test waits until the process has actually used the conflicting resource.
Solution
Closes #3489.
Review
Anyone can review this PR.
It's causing 1-3 test failures per day, so I'm marking it as high priority.
Reviewer Checklist