Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mergify): do not wait for deprecated Cloud Build #3509

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

gustavovalverde
Copy link
Member

Motivation

Cloud Build was recently removed, and Mergify is expecting a result from a non-existing action.

Solution

Remove cloud build check from Mergify's as a requirement for speculative checks.

Review

@conradoplg

Cloud Build was recently removed, and Mergify is expecting a result from a non-existing action.
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dconnolly dconnolly enabled auto-merge (rebase) February 10, 2022 19:58
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #3509 (53d9ded) into main (499ae89) will increase coverage by 0.23%.
The diff coverage is 74.66%.

@@            Coverage Diff             @@
##             main    #3509      +/-   ##
==========================================
+ Coverage   78.34%   78.57%   +0.23%     
==========================================
  Files         267      273       +6     
  Lines       31526    31900     +374     
==========================================
+ Hits        24698    25066     +368     
- Misses       6828     6834       +6     

@gustavovalverde gustavovalverde changed the title fix(mergify): do not wait for depecrated Cloud Build fix(mergify): do not wait for deprecated Cloud Build Feb 10, 2022
@teor2345
Copy link
Contributor

The macOS job took 90 minutes to fetch the parameters, and the command didn't actually output any logs.
(I think it usually outputs info-level logs, but maybe the defaults are different for an example command.)
https://github.com/ZcashFoundation/zebra/runs/5146825555?check_suite_focus=true#step:12:13

So I restarted the CI jobs.

@dconnolly dconnolly merged commit d2e58df into main Feb 10, 2022
@dconnolly dconnolly deleted the fix-mergify-cloudbuild branch February 10, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants