fix(mergify): restrict merges with unresolved threads

[gustavovalverde]

Motivation

We've had a few cases of Mergify merging reviewed PR's with unresolved comments.

Solution

• Added "#review-threads-unresolved=0" to all pull_request_rules which will prevent merges with unresolved threads.

Review

@dconnolly

[teor2345]

Thanks!

[dconnolly]

Nice! I was looking for something like this in the Mergify docs and just did not have the grep-fu to find it 🙏🙏🙏

[teor2345]

@dconnolly we don't need to set GitHub auto-merge any more, because mergify will do the merge.

[dconnolly]

@dconnolly we don't need to set GitHub auto-merge any more, because mergify will do the merge.

Not for changes to Mergify config, which makes sense:

[teor2345]

Ah right, I just read that:

For security reason, Mergify will never automatically merge a pull request if it changes the Mergify configuration file.

https://docs.mergify.com/getting-started/#configuration

[codecov]

Codecov Report

Merging #3453 (a079d7b) into main (499ae89) will decrease coverage by 0.29%.
The diff coverage is 78.91%.

@@            Coverage Diff             @@
##             main    #3453      +/-   ##
==========================================
- Coverage   78.34%   78.04%   -0.30%     
==========================================
  Files         267      272       +5     
  Lines       31526    31532       +6     
==========================================
- Hits        24698    24609      -89     
- Misses       6828     6923      +95