refactor: address comments from #3415: Prepare for changes in ZIP-244 #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
- Coverage 78.34% 78.15% -0.19%
==========================================
Files 267 272 +5
Lines 31526 31532 +6
==========================================
- Hits 24698 24644 -54
- Misses 6828 6888 +60 |
jvff
reviewed
Jan 31, 2022
Comment on lines
+483
to
+484
| } else { | ||
| continue; |
There was a problem hiding this comment.
Optional nit: this feels redundant to me 🤔
Suggested change
| } else { | |
| continue; |
There was a problem hiding this comment.
I kinda appreciate the explicit continue in the loop 😅
teor2345
changed the title
Co-authored-by: Janito Vaqueiro Ferreira Filho <[email protected]>
dconnolly
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#3415 was accidentally merged without addressing review comments. This PR addresses them.
Specifications
Designs
Solution
Review
Reviewer Checklist
Follow Up Work