-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate JoinSplit proofs #3128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
force-pushed
the
validate-joinsplit-proofs
branch
from
December 1, 2021 18:26
ea222fc
to
747fea9
Compare
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
reviewed
Dec 1, 2021
dconnolly
suggested changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Some suggestions and proposals
3 tasks
dconnolly
reviewed
Dec 9, 2021
dconnolly
reviewed
Dec 9, 2021
dconnolly
reviewed
Dec 9, 2021
dconnolly
reviewed
Dec 9, 2021
dconnolly
reviewed
Dec 9, 2021
dconnolly
reviewed
Dec 9, 2021
dconnolly
reviewed
Dec 10, 2021
dconnolly
reviewed
Dec 10, 2021
dconnolly
reviewed
Dec 10, 2021
Some rustdoc improvements and a merge conflict to resolve but functionally ✅ |
Co-authored-by: Deirdre Connolly <[email protected]>
…validate-joinsplit-proofs
conradoplg
force-pushed
the
validate-joinsplit-proofs
branch
from
December 10, 2021 14:41
d9c668b
to
63ecd44
Compare
👍 Conflicts solved |
dconnolly
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to validate JoinSplit Groth16 proofs from post-Sapling Sprout transactions. (Pre-Sapling use BCTV14 proofs, but since we checkpoint on Canopy, we don't need to validate them.)
Specifications
JoinSplit descriptions are described in https://zips.z.cash/protocol/protocol.pdf#joinsplitdesc
The primary input encoding is not documented yet; see https://github.com/zcash/librustzcash/blob/0ec7f97c976d55e1a194a37b27f247e8887fca1d/zcash_proofs/src/sprout.rs#L152-L166 for the reference implementation.
Designs
Solution
spend_prepared_verifying_key
tojoinsplit_prepared_verifying_key
which is more appropriatezcash_proofs
, will be done in Support batch verification of JoinSplit Groth16 proofs #3127Closes #322
Review
@dconnolly and/or @upbqdn can review this.
Reviewer Checklist
Follow Up Work
Actually using this to validate proofs will be done in #1835
Adding support for batch verification is #3127