Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement graceful shutdown for the peer set #3071

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 18, 2021

Motivation

The peer set can keep running, even when some of its background tasks have shut down.
But when Zebra starts to shut down, we want to cancel all the tasks quickly.

This should speed up some tests, and avoid test failures.
Quick shutdowns also make Zebra easier to use.

This is unexpected work in sprint 23.

Solution

  • when one peer set task shuts down, shut the rest of them down

Review

@oxarbitrage can review this low priority PR.

Reviewer Checklist

  • Code makes sense
  • Existing tests pass

Follow Up Work

@teor2345 teor2345 added C-bug Category: This is a bug P-Low I-integration-fail Continuous integration fails, including build and test failures I-usability Zebra is hard to understand or use A-network Area: Network protocol updates or fixes labels Nov 18, 2021
@teor2345 teor2345 added this to the 2021 Sprint 23 milestone Nov 18, 2021
@teor2345 teor2345 requested a review from oxarbitrage November 18, 2021 00:50
@teor2345 teor2345 self-assigned this Nov 18, 2021
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thank you for adding documentation too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants