Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tweaks of the README #3006

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Some tweaks of the README #3006

merged 4 commits into from
Nov 2, 2021

Conversation

dconnolly
Copy link
Contributor

Motivation

Clarify some points in our updated README

Solution

Fix some small errors
Clarify the remaining consensus rules to be fully validating at NU5 activation
Elaborate on Zebra advantages

Review

Anyone can review

Reviewer Checklist

  • Changes make sense

@dconnolly dconnolly added A-docs Area: Documentation C-cleanup Category: This is a cleanup P-Low labels Nov 2, 2021
@dconnolly dconnolly added this to the 2021 Sprint 22 milestone Nov 2, 2021
@dconnolly dconnolly requested review from mpguerra, hyphalabdan and a team November 2, 2021 20:01
@dconnolly dconnolly self-assigned this Nov 2, 2021
teor2345
teor2345 reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, I have a suggestion for a further improvement.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dconnolly dconnolly requested a review from teor2345 November 2, 2021 21:50
@dconnolly dconnolly enabled auto-merge (rebase) November 2, 2021 21:51
teor2345
teor2345 approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dconnolly dconnolly merged commit 2a986aa into main Nov 2, 2021
@dconnolly dconnolly deleted the readme-copy branch November 2, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@mpguerra mpguerra Awaiting requested review from mpguerra

@hyphalabdan hyphalabdan Awaiting requested review from hyphalabdan

Assignees

@dconnolly dconnolly

Labels
A-docs Area: Documentation C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
2021 Sprint 22
Development

Successfully merging this pull request may close these issues.
2 participants
@dconnolly @teor2345