Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for Beta release #2894

Merged
merged 10 commits into from
Oct 29, 2021
Merged

Conversation

conradoplg
Copy link
Collaborator

Motivation

For beta release it would be good to improve documentation to make it more clear what is the purpose of Zebra and how to install and run it.

Specifications

Designs

Solution

Closes #2870

Review

Just a draft for now. Feel free to suggest any changes.
Not very confident on the content, just wanted to get it started.

Something I'm not sure about: if we choose to avoid the repetition between README and user guide about setup procedure, should we keep it in the README or in the user guide?

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@teor2345
Copy link
Contributor

Something I'm not sure about: if we choose to avoid the repetition between README and user guide about setup procedure, should we keep it in the README or in the user guide?

I have no strong opinions here.

But in general, I think a shorter README is better, as long as it has a brief summary of the setup.

@teor2345
Copy link
Contributor

teor2345 commented Oct 17, 2021

macOS failed with an unrelated unit test timeout, PR #2895 should fix that timeout.

(This failure is not a blocker for this PR merging.)

@teor2345 teor2345 added the P-Low label Oct 18, 2021
@mpguerra
Copy link
Contributor

Great start! Thank you for getting the conversation going on this :)

README.md Outdated Show resolved Hide resolved
@mpguerra mpguerra mentioned this pull request Oct 28, 2021
3 tasks
@mpguerra mpguerra added P-Medium and removed P-Low labels Oct 28, 2021
@conradoplg
Copy link
Collaborator Author

Updated:

  • 9a36701: incorporate some of the text from the last newsletter
  • 6efde14: organized the README / user docs
    • Moved the detailed instructions to the docs and kept a slightly reduced version in the README
    • Moved "Architecture" entirely to the docs

I think the original commit (4d65495) is too verbose and should be trimmed down a bit (if we actually want to include it)

like to find out more or get involved!

Zcash is a cryptocurrency designed to preserve the user's privacy. Like most
Copy link
Contributor

@mpguerra mpguerra Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these additions to the README, they give a good background. One thing I remember from our usability studies early this year is that people "who know what they are doing" like to get to the "Getting Started" section to start running things straightaway.

I wonder if we can have a short table of contents like list of anchors at the start that jump to:

  • About
  • Alpha/Beta Release
  • Getting Started
  • System Requirements
  • Current Features
  • Known Issues
  • Future Work
  • etc...

So that experienced users can skip the intro and go directly to the sections they are interested in.

We may not want to have all of the above and just pick and choose the sections we think people are most likely to want to skip down to...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like table of contents! Added in 4670ddd, I've also organized the heading levels to something that I felt made more sense

@conradoplg conradoplg marked this pull request as ready for review October 29, 2021 14:03
@conradoplg conradoplg mentioned this pull request Oct 29, 2021
24 tasks
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small spacing issues

book/src/dev/overview.md Outdated Show resolved Hide resolved
book/src/dev/overview.md Outdated Show resolved Hide resolved
book/src/dev/overview.md Outdated Show resolved Hide resolved
book/src/dev/overview.md Outdated Show resolved Hide resolved
book/src/dev/overview.md Outdated Show resolved Hide resolved
book/src/dev/overview.md Outdated Show resolved Hide resolved
book/src/dev/overview.md Outdated Show resolved Hide resolved
book/src/dev/overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Thanks for the work here.

@oxarbitrage oxarbitrage enabled auto-merge (squash) October 29, 2021 18:31
@oxarbitrage oxarbitrage merged commit 4367b23 into main Oct 29, 2021
@oxarbitrage oxarbitrage deleted the improve-documentation branch October 29, 2021 19:25
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Zebra documentation for beta release
5 participants