Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ed25519-zebra 3.0.0 #2864

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Upgrade to ed25519-zebra 3.0.0 #2864

merged 4 commits into from
Oct 12, 2021

Conversation

dconnolly
Copy link
Contributor

@dconnolly dconnolly commented Oct 12, 2021 •
edited
Loading

Motivation

Updated dependencies rand and rand_core, but especially updated zeroize which has a security fix.

Review

This is low priority for mempool, but good to have as we prep for beta release.

Reviewer Checklist

  • Tests for Expected Behaviour
  • Tests for Errors

@dconnolly dconnolly added A-dependencies Area: Dependency file updates P-Medium labels Oct 12, 2021
teor2345
teor2345 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, another git dependency fixed!

@teor2345 teor2345 enabled auto-merge (squash) October 12, 2021 22:40
@dconnolly dconnolly added this to the 2021 Sprint 20 milestone Oct 12, 2021
@teor2345 teor2345 merged commit e36ec34 into main Oct 12, 2021
@teor2345 teor2345 deleted the ed25519-zebra-3 branch October 12, 2021 23:42
@teor2345 teor2345 mentioned this pull request Oct 14, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@dconnolly dconnolly

Labels
A-dependencies Area: Dependency file updates
Projects
None yet
Milestone
2021 Sprint 20
Development

Successfully merging this pull request may close these issues.
2 participants
@dconnolly @teor2345