Test if the mempool storage is cleared #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
previously requested changes
Sep 30, 2021
jvff
force-pushed
the
test-if-mempool-storage-is-cleared
branch
2 times, most recently
from
74f0f5c to
68ae5ae
Compare
teor2345
previously approved these changes
Oct 1, 2021
teor2345
dismissed
conradoplg’s stale review
It looks like Conrado has approved all the changes
|
Actually, I'm not sure how to resolve these conflicts, so I'll let @jvff do it. |
Make it consistent with other test modules and prepare for adding property tests.
Make it consistent with the general guidelines followed on other modules.
Allow these types to be used in other crates for testing purposes.
Make it easy to generate random `ChainTipBlock`s for usage in property tests.
Reduce the repeated test configuration attributes and make it easier to see what is test specific and what is part of the general implementation.
Performs a dummy call just so that `poll_ready` gets called.
Replace the custom dummy requests with the helper method.
A chain reset should force the mempool storage to be cleared so that transaction verification can restart using the new chain tip.
If the block synchronizer falls behind and then starts catching up again, the mempool should be disabled and therefore the storage should be cleared.
jvff
force-pushed
the
test-if-mempool-storage-is-cleared
branch
from
68ae5ae to
c9a2d92
Compare
|
Merge conflicts solved. @conradoplg, could you please take another look to see if I haven't missed anything? 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This started as part of the work for #2723, but @teor2345 realized that this had already been implemented by @conradoplg as part of #2786. I scrapped the original implementation, but thought that maybe the property tests I had written might be useful to keep.
Solution
This PR contains two PRs. Both test if the mempool storage should be cleared, but on different events:
Review
@conradoplg and @teor2345. I think the most important thing to decide in this review is if these tests are useful or just redundant.
Reviewer Checklist