Use complete addition instead of incomplete addition inside sinsemilla_commit #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
added
A-consensus
dconnolly
force-pushed
the
sinsemilla-commit-use-complete-addition
branch
from
dba5aa1 to
bc6fc8b
Compare
conradoplg
approved these changes
Sep 28, 2021
upbqdn
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To match zcash/orchard#209
Specifications
Protocol spec should be updated in a few hours to reflect these changes.
Solution
Use complete addition instead of incomplete addition inside
sinsemilla_commit()Review
@conradoplg @str4d @daira @upbqdn
Reviewer Checklist
Follow Up Work