-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics for initial peer network protocol versions #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
NU-5
Network Upgrade: NU5 specific tasks
P-Medium
A-network
Area: Network protocol updates or fixes
labels
Sep 28, 2021
teor2345
force-pushed
the
net-proto-vers-metrics
branch
2 times, most recently
from
September 29, 2021 01:36
4c8ba0d
to
54d94a7
Compare
Currently this just shows the initial peer count from each seed.
teor2345
force-pushed
the
net-proto-vers-metrics
branch
from
September 29, 2021 01:43
54d94a7
to
d8e7493
Compare
upbqdn
approved these changes
Sep 29, 2021
Adding |
dconnolly
approved these changes
Sep 29, 2021
This was referenced Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-network
Area: Network protocol updates or fixes
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
NU-5
Network Upgrade: NU5 specific tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of ticket #2797, we want to check the network protocol versions of the peers supplied by the Zcash DNS seeders.
Designs
Zebra already has this information, we just need to add it to the logs and metrics.
Solution
Seed Peer DNS Resolution:
Network Protocol Versions
Review
Anyone can review this PR, but I think @conradoplg or @upbqdn have set up a Grafana instance already?
Merging this PR isn't urgent.
Reviewer Checklist
Follow Up Work