Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update num-bigint to 0.3.3 to fix rust nightly compilation #2734

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Update num-bigint to 0.3.3 to fix rust nightly compilation #2734

merged 1 commit into from
Sep 3, 2021

Conversation

conradoplg
Copy link
Collaborator

@conradoplg conradoplg commented Sep 3, 2021 •
edited by dconnolly
Loading

Motivation

Rust nightly broke num-bigint rust-lang/rust#88581 rust-num/num-bigint#218, which was fixed with a new release of the crate

Specifications

Designs

Solution

Update num-bigint to 0.3.3

Review

Without this all CI builds will fail, so it's important to review & merge soon.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@dconnolly dconnolly enabled auto-merge (rebase) September 3, 2021 19:58
@dconnolly dconnolly added this to the 2021 Sprint 17 milestone Sep 3, 2021
@dconnolly dconnolly merged commit 7abc98a into main Sep 3, 2021
@dconnolly dconnolly deleted the update-num-bigint branch September 3, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

Assignees

@conradoplg conradoplg

Labels
None yet
Projects
None yet
Milestone
2021 Sprint 17
Development

Successfully merging this pull request may close these issues.
2 participants
@conradoplg @dconnolly