Verify inbound PushTransactions #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
teor2345
reviewed
Sep 2, 2021
teor2345
reviewed
Sep 2, 2021
conradoplg
force-pushed
the
verify-push-transactions
branch
from
e86d62b to
0195a7a
Compare
dconnolly
reviewed
Sep 8, 2021
|
As we discussed yesterday i removed the grafana changes in 9972d9e so they can be added in a stand alone PR |
dconnolly
reviewed
Sep 8, 2021
oxarbitrage
previously approved these changes
Sep 8, 2021
There was a problem hiding this comment.
I added a new ticket to track the tests we have missing #2745
dconnolly
reviewed
Sep 8, 2021
oxarbitrage
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transactions can be directly pushed to nodes (instead of their IDs being advertised) and we need to verify them before adding to the mempool.
Specifications
Designs
Solution
This adds a new function to the transaction dowloader/verifier to just verify a pushed transaction.
Closes #2692
Review
Must be merged after #2718.
Probably anyone working on the mempool can review this.
Reviewer Checklist
Follow Up Work