Implement a WtxId struct, and use it in Zebra's external network protocol #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
teor2345
commented
Aug 13, 2021
teor2345
commented
Aug 13, 2021
teor2345
changed the title
And derive `Hash`, just like transaction IDs. Don't derive `serde` for now, because it's not needed.
teor2345
force-pushed
the
wtxid-struct-network
branch
from
4d08bec to
fd803c2
Compare
This was referenced Aug 16, 2021
conradoplg
approved these changes
Aug 16, 2021
dconnolly
reviewed
Aug 17, 2021
| /// [ZIP-244]: https://zips.z.cash/zip-0244.. | ||
| #[derive(Copy, Clone, Eq, PartialEq, Debug)] | ||
| /// Note: Zebra displays transaction and block hashes in big-endian byte-order, | ||
| /// following the u256 convention set by Bitcoin and zcashd. |
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| let mut reversed_bytes = self.0; | ||
| reversed_bytes.reverse(); | ||
| f.write_str(&hex::encode(&reversed_bytes)) |
| // TODO: Actually handle this variant once the mempool is implemented | ||
| Wtx([u8; 64]), | ||
| // TODO: Actually handle this variant once the mempool is implemented (#2449) | ||
| Wtx(transaction::WtxId), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to handle wide transaction IDs from the network, Zebra needs to:
idandauth_datafieldsinv,getdata, andnotfoundmessages)Specifications
https://zips.z.cash/zip-0239#specification
Solution
Changes
WtxIdtype for wide transaction IDsWtxIdtype in external network protocol messagesBug Fixes
AuthDigestdisplay order match transaction IDsTests
transaction::Hashtest to tests moduleThis is part of ticket #2449, but it does not close that ticket.
Review
Anyone can review this PR.
It's blocking all of the mempool work that needs wide transaction IDs.
It's based on PR #2547, so it might need rebasing after that PR merges to
main.Reviewer Checklist
Follow Up Work
Create an
UnminedTxIdenum, to abstract over unmined v4 and v5 transactions in Zebra's internal network protocolUnminedTxIdis also blocking all of the mempool work that needs wide transaction IDsThis change is