Update to google-github-actions/setup-gcloud in workflows #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
|
Ran CD workflow again as there was an instance template collision? error? on the run teor kicked off 👍
|
dconnolly
approved these changes
Jul 27, 2021
dconnolly
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @teor2345)
mpguerra
added a commit
that referenced
this pull request
Jul 27, 2021
mpguerra
added a commit
that referenced
this pull request
Jul 29, 2021
* Draft CHANGELOG for Zebra 1.0.0-alpha.14 * Add PR #2533 to CHANGELOG * Apply suggestions from code review Co-authored-by: teor <[email protected]> * Remove entry about updating the changelog * move #2497 * add #2529 * Add a missing space * Add #2458, #2525, #2486, #2542 and #2539 to CHANGELOG Co-authored-by: teor <[email protected]> Co-authored-by: Deirdre Connolly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Google Cloud just got rid of some deprecated GitHub action names.
https://github.com/ZcashFoundation/zebra/runs/3145563888#step:4:14
API Reference
See https://github.com/google-github-actions/setup-gcloud#use-google-github-actionssetup-gcloud
Solution
Review
Anyone can review this PR.
This change is urgent because every
mainmerge will fail until it is fixed.I manually launched the Google Cloud workflows:
The first CD run tests creating the instance group & deploying. We can test deploying CD updates by merging to the
mainbranch.Reviewer Checklist
mainThis change is