Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the nullifier test module #2504

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Rename the nullifier test module #2504

merged 1 commit into from
Jul 20, 2021

Conversation

teor2345
Copy link
Contributor

Motivation

I'm planning on adding a transparent tests module as part of #2231.

Solution

  • Change a module name

Review

@oxarbitrage can review this tiny PR, it's not urgent.

Reviewer Checklist

  • Code works?

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-Medium labels Jul 16, 2021
@teor2345 teor2345 requested a review from oxarbitrage July 16, 2021 06:35
@teor2345 teor2345 self-assigned this Jul 16, 2021
@teor2345 teor2345 marked this pull request as draft July 19, 2021 03:24
@teor2345

This comment has been minimized.

@teor2345 teor2345 force-pushed the rename-nullifier-tests branch from ef0c67b to 2e67a97 Compare July 20, 2021 02:51
@teor2345 teor2345 marked this pull request as ready for review July 20, 2021 02:51
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this change but another option to organize them and highlight the fact they are prop tests is maybe:

tests/prop/nullifier.rs
tests/prop/transparent.rs

This way if we ever want to do the same with unit tests we can use:

tests/vectors/nullifiers.rs
tests/vectors/transparent.rs

@teor2345
Copy link
Contributor Author

teor2345 commented Jul 20, 2021

I am ok with this change but another option to organize them and highlight the fact they are prop tests is maybe:

tests/prop/nullifier.rs
tests/prop/transparent.rs

This way if we ever want to do the same with unit tests we can use:

tests/vectors/nullifiers.rs
tests/vectors/transparent.rs

I'd like to make that change after we finish up the rest of the state work. Because we might need to change these tests from proptests to fixed test vectors as part of that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants