Add an OrderedUtxo type for transparent spend validation #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-consensus
teor2345
changed the base branch from
sapling-orchard-duplicate-nullifiers
to
main
jvff
previously approved these changes
Jul 16, 2021
This change allows us to check that transparent spends use outputs from earlier in their block. (But we don't actually do that check yet.) We need to keep the order of UTXOs when we're contextually verifying each new block that is added to a chain. But the block order is irrelevant for UTXOs stored in the state.
jvff
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to track transaction order in each block, until we have validated transparent spends.
Specifications
https://developer.bitcoin.org/reference/block_chain.html#merkle-trees
Solution
OrderedUtxotype which includes aUtxoand the transaction index in the blockUtxountil the transaction is validated in the non-finalized chainThis PR is part of #2231, but it doesn't close that ticket.
Review
@jvff can review this PR.
I think it might conflict with some of @oxarbitrage's value pools work, so it might be good to get it in soon.
Reviewer Checklist
The tests will come in a future PR, as part of testing transparent spends.