Stop ignoring sapling binding signature errors #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
3 tasks
dconnolly
approved these changes
Jul 9, 2021
|
This PR is blocked by PR #2463 - we want to test the modified transaction verifier using the cached state tests. |
|
A macOS builder failed due to #2474, so I restarted all the jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We fixed the sighash bug that was causing sapling binding signature errors, so now we need to stop ignoring those errors.
Part of #1939, which got closed a bit too early.
Review
@conradoplg can review this fix. It's not urgent.
Reviewer Checklist