Add a TypeNameToDebug formatter to zebra_chain #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This formatter makes it much easier to diagnose proptest errors. It will be used in a future PR. Implement Arbitrary and DerefMut for all the formatters. Also make the formatter type bounds consistent, to produce better compiler errors.
teor2345
added
A-rust
jvff
previously approved these changes
Jul 9, 2021
Co-authored-by: Janito Vaqueiro Ferreira Filho <[email protected]>
jvff
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This formatter makes it much easier to diagnose proptest errors. Without this formatter, the output of proptest failures can extend across hundreds of terminal lines.
This formatter will be used in a future PR to proptest the double-spend checks.
Change Risk
This is a low-risk change, because these formatters are only used in the tests and logs.
Solution
This is part of ticket #2231, but it does not close that ticket.
Review
Anyone can review this PR. It's not urgent.
Reviewer Checklist
These methods will be tested as part of the double-spend tests in a future PR.
Follow Up Work
Actually check for double-spends