Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG for Zebra 1.0.0-alpha.12 #2414

Merged
merged 5 commits into from
Jul 2, 2021
Merged

Conversation

mpguerra
Copy link
Contributor

Motivation

Update CHANGELOG for Zebra 1.0.0-alpha.12 release

Review

@ZcashFoundation/zebra-team

Reviewer Checklist

  • Changes are under the correct categories
  • All significant changes are listed
  • Descriptions are non-developer friendly

Follow Up Work

Once release version update PR is merged, review any new merges and update CHANGELOG contents and release date.

@teor2345
Copy link
Contributor

The build failure is spurious, see #2418

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@mpguerra
Copy link
Contributor Author

mpguerra commented Jul 1, 2021

The build failure is spurious, see #2418

I tried with a branch name of v1.0.0-alpha.12CHANGELOG in #2429 and I still got the same error.

But for the release version update PR the branch name was v1.0.0-alpha.12 and I didn't get a failure, so I'm not sure which characters would be the issue here...

@mpguerra
Copy link
Contributor Author

mpguerra commented Jul 1, 2021

I also added all new PRs up to #2415 to the CHANGELOG

@mpguerra mpguerra marked this pull request as ready for review July 1, 2021 08:33
@mpguerra mpguerra mentioned this pull request Jul 1, 2021
3 tasks
@mpguerra mpguerra requested review from teor2345 and a team July 1, 2021 08:44
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Janito Vaqueiro Ferreira Filho <[email protected]>
@teor2345
Copy link
Contributor

teor2345 commented Jul 1, 2021

The build failure is spurious, see #2418

I tried with a branch name of v1.0.0-alpha.12CHANGELOG in #2429 and I still got the same error.

But for the release version update PR the branch name was v1.0.0-alpha.12 and I didn't get a failure, so I'm not sure which characters would be the issue here...

It might also be a combination of length and special characters, or the presence of alphanumerics in the last version component. We also just changed the commands in that workflow, which could change how the lines are parsed.

Anyway we can sort out the details in #2429.

CHANGELOG.md Outdated Show resolved Hide resolved
teor2345
teor2345 previously approved these changes Jul 1, 2021
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, let's merge right before we tag the release.

@mpguerra mpguerra merged commit d30b95d into main Jul 2, 2021
@mpguerra mpguerra deleted the v1.0.0-alpha.12_CHANGELOG branch July 2, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants