Release Blocker? Disable IPv6 tests when $ZEBRA_SKIP_IPV6_TESTS is set #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to disable IPv6 tests in environments where IPv6 is not configured.
teor2345
added
C-bug
3 tasks
jvff
reviewed
Jun 28, 2021
jvff
previously approved these changes
Jun 28, 2021
fastmod '"ZEBRA_SKIP_NETWORK_TESTS"' zebra_test::net::ZEBRA_SKIP_NETWORK_TESTS fastmod '"ZEBRA_SKIP_IPV6_TESTS"' zebra_test::net::ZEBRA_SKIP_IPV6_TESTS
fastmod --fixed-strings 'env::var_os(zebra_test::net::ZEBRA_SKIP_NETWORK_TESTS).is_some()' 'zebra_test::net::zebra_skip_network_tests()' fastmod --fixed-strings 'env::var_os(zebra_test::net::ZEBRA_SKIP_IPV6_TESTS).is_some()' 'zebra_test::net::zebra_skip_ipv6_tests()'
teor2345
commented
Jun 29, 2021
teor2345
commented
Jun 29, 2021
|
This PR is ready for another review. Since I made a larger change than @jvff might have expected, I'd like another review before we merge. |
jvff
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of Zebra's new network tests fail in our
mainbranch Google Cloud CI, but those failures are hidden due to bug #2403.We need to fix this bug before we can stop hiding those failures.
Solution
This allows users to disable IPv6 tests in environments where IPv6 is not configured.
Review
@jvff reviewed PR #2277, which introduced these tests. I think this might be urgent, because we don't want to release broken code.
Reviewer Checklist
Follow Up Work
Eventually we'll want to test in IPv6-only and non-standard IPv4 localhost environments.